Repository navigation
Conversation
|
Yesterday I submitted an issue for this feature, and today I decided to take a shot at implementing it myself. Since this is my first pull request, any feedback or suggestions would be greatly appreciated |
|
I tested the pr on my pc and I really like it. |
|
Thanks! I overlooked that, will fix it soon. |
|
Fixed: tools no longer draw while zooming with Ctrl + drag. A configurable keybind could be added later. |
|
Hi, will try it tomorrow again but i think there needs to be a _delayBakeUnlessSmooth after zooming + i think multiple inputs can break the implementation?
|
|
Hmm, im not the fan adding explicit handler checks in input manager. Maybe we can find a better solution? What do you think? |
|
I'm thinking if we could maybe change the current ctrl to shift or alt/something similiar for the tools to keep ctrl for the zoom? |
|
Maybe instead we can change the zooming to only work with middle click plus ctrl |
|
I tried Ctrl + middle click and it feels better for the mouse. For the stylus, I think zoom only makes sense on the barrel button that is mapped to the hand tool (for me the secondary button). Then moving is just that button, and zooming is that button + Ctrl. The downside is that this button is reserved for moving and zooming, so it can't be used for something else. I think that is okay, Krita does something similar. What do you think? Edit: just commited so feel free to try when you have time |
|
Hmm is this really better than just using shift or alt inside pen/other tools. since many mouses aren't nice using with middle click and secondary stylus buttons can be customized |
|
You are right it is hard with middle click I think Alt+click would be so much more suitable So the tools can use Ctrl freely |
|
But then we have conflicts with alt. I would just change to tools to not use ctrl |
|
I heard Photoshop and similar apps use Space to pan around, and Space + another key to zoom. Would that make sense It would separate navigation. But I'm not sure if it conflicts with anything |
|
We have shift and space for rotation |
|
It might be nice rotation, panning and zooming all uses space in some sort |
|
Zoom with |
|
I tested the latest version with Ctrl + Space + drag and found two remaining issues:
Can you look at it? |
Description
This PR introduces a global
Ctrl+Dragzoom functionality that works consistently across all tools. It also resolves a UX issue where the Hand Tool would attempt to pan the canvas simultaneously while zooming.How to Test
Ctrland drag the mouse/stylus. Verify that the canvas zooms smoothly without leaving ink or erasing.Ctrland drag. Verify that the canvas only zooms and does not pan or jitter.Screencast_20261029_162008.mp4