hal: Fix implementation types and small adjustments#4260
Open
BsAtHome wants to merge 1 commit into
Open
Conversation
grandixximo
reviewed
Jul 23, 2026
Contributor
Contributor
Author
Why and where does that fail? |
BsAtHome
force-pushed
the
halgs_structural-missing
branch
from
July 23, 2026 06:46
024ef5d to
b44b049
Compare
grandixximo
reviewed
Jul 23, 2026
Contributor
Author
|
BTW, the next PR will provide the HAL query API. That should make most changes to these parts complete. |
Contributor
I will double check the claim in a few hours once I'm on a linux machine arm sid is broken, are we closing an eye on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
This PR introduces hal_strerror() for textual representation of the negative error value from many of the HAL functions. The return value of some HAL functions will be adapted to become more fine-grained later. Currently, they mostly return -EINVAL, which often does not describe the actual error encountered. Changing the return value should not pose any problem because the code that actually checks return values looks for equality with zero or less than zero. Returning a more differentiating (negative) value does not functionally alter that code but allows better messages to be generated moving forward.