Skip to content

fix(ci): only submit coverage from ubuntu (macOS runner rejects the coveralls Homebrew tap)#171

Draft
jeswr wants to merge 1 commit into
LinkedSoftwareDependencies:masterfrom
jeswr:fix/ci-coveralls-macos
Draft

fix(ci): only submit coverage from ubuntu (macOS runner rejects the coveralls Homebrew tap)#171
jeswr wants to merge 1 commit into
LinkedSoftwareDependencies:masterfrom
jeswr:fix/ci-coveralls-macos

Conversation

@jeswr

@jeswr jeswr commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Note: This PR was opened by @jeswr's AI agent and is intended for @jeswr to review before it goes to the maintainers. cc @jeswr

The break

Since 2026-07-03, CI is red on every PR and on master for this repo — even though the build, all 865 tests (100% coverage), and webpack all pass.

The cause is not any PR. GitHub's macOS runners now refuse to load the untrusted coverallsapp/coveralls Homebrew tap (a Homebrew policy change: "Refusing to load formula … from untrusted tap"). The test matrix job runs on ubuntu-latest, windows-latest, and macos-latest, and its "Submit coverage results" step uses coverallsapp/github-action@v2. On macOS that step now fails, and because the matrix is fail-fast, the failure cancels the rest of the matrix → the whole workflow shows red despite everything passing.

The fix

Scope the "Submit coverage results" step to ubuntu-latest only:

       - name: Submit coverage results
+        if: matrix.os == 'ubuntu-latest'
         uses: coverallsapp/github-action@v2

Coverage from a single OS is sufficient, and this also sidesteps per-node-version flag-name collisions across operating systems. The separate coveralls finish job (runs-on: ubuntu-latest) is unchanged.

This is a one-line change that unblocks CI for the entire repository.

Next steps

@jeswr will review, mark this ready, and tag the maintainers.


🤖 Generated with Claude Code

Review timing: This draft was prepared with Claude; I (@jeswr) will personally review it before it progresses. I'm currently batching a lot of work in flight, so expect active review Wednesday–Friday (8–10 July).

…overalls Homebrew tap)

GitHub's macOS runners now refuse to load the untrusted coverallsapp/coveralls
Homebrew tap, causing the 'Submit coverage results' step to fail on macOS and
fail-fast to cancel the rest of the matrix. Scope that step to ubuntu-latest;
coverage from a single OS is sufficient and this also avoids per-node-version
flag-name collisions across operating systems.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant