fix(ci): only submit coverage from ubuntu (macOS runner rejects the coveralls Homebrew tap)#171
Draft
jeswr wants to merge 1 commit into
Draft
Conversation
…overalls Homebrew tap) GitHub's macOS runners now refuse to load the untrusted coverallsapp/coveralls Homebrew tap, causing the 'Submit coverage results' step to fail on macOS and fail-fast to cancel the rest of the matrix. Scope that step to ubuntu-latest; coverage from a single OS is sufficient and this also avoids per-node-version flag-name collisions across operating systems. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The break
Since 2026-07-03, CI is red on every PR and on
masterfor this repo — even though the build, all 865 tests (100% coverage), and webpack all pass.The cause is not any PR. GitHub's macOS runners now refuse to load the untrusted
coverallsapp/coverallsHomebrew tap (a Homebrew policy change: "Refusing to load formula … from untrusted tap"). Thetestmatrix job runs onubuntu-latest,windows-latest, andmacos-latest, and its "Submit coverage results" step usescoverallsapp/github-action@v2. On macOS that step now fails, and because the matrix is fail-fast, the failure cancels the rest of the matrix → the whole workflow shows red despite everything passing.The fix
Scope the "Submit coverage results" step to
ubuntu-latestonly:- name: Submit coverage results + if: matrix.os == 'ubuntu-latest' uses: coverallsapp/github-action@v2Coverage from a single OS is sufficient, and this also sidesteps per-node-version flag-name collisions across operating systems. The separate
coverallsfinish job (runs-on: ubuntu-latest) is unchanged.This is a one-line change that unblocks CI for the entire repository.
Next steps
@jeswr will review, mark this ready, and tag the maintainers.
🤖 Generated with Claude Code