Skip to content

Cover HTTPS access from worker networks - #153

Merged
vitormattos merged 3 commits into
mainfrom
fix/internal-proxy-https
Oct 5, 2026
Merged

vitormattos merged 3 commits into
mainfrom
fix/internal-proxy-https

Conversation

@vitormattos

@vitormattos vitormattos commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Add integration coverage for accessing the shared HTTPS proxy from a worker container through the worker's canonical hostname.

Why

LibreSign's Dev Container integration exposed a gap in the proxy test suite: host-loopback HTTPS was covered, but worker-network HTTPS was not.

The regression test now verifies both TCP ports 80/443 and a real HTTPS request through:

worker container
  -> <worker>.localhost
  -> shared proxy
  -> backend

The test confirmed that the current proxy implementation supports this path. The failure observed in LibreSign came from starting its optional Playwright runner and probing the proxy immediately; LibreSign now starts the runner explicitly and waits/retries through a real Chromium smoke test.

This PR therefore adds the missing NCDD regression coverage without changing runtime behavior.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos changed the title Test HTTPS access from worker networks Cover HTTPS access from worker networks Oct 5, 2026
@vitormattos
vitormattos merged commit da85c7d into main Oct 5, 2026
13 checks passed
@vitormattos
vitormattos deleted the fix/internal-proxy-https branch October 5, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant