Skip to content

📸 docs: Add Current Pull Request Screenshots and Drop Released Pending Labels - #809

Merged
berry-13 merged 1 commit into
mainfrom
docs/pull-requests-remove-pending
Oct 18, 2026
Merged

berry-13 merged 1 commit into
mainfrom
docs/pull-requests-remove-pending

Conversation

@berry-13

@berry-13 berry-13 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Rescoped. LibreChat-AI/LibreChat#16876 and #821 both merged after this PR was opened, so its original goal (removing the default-on docs) no longer applies. The branch is now rebuilt on main and keeps #821's content.

  • Adds screenshots of the current dev UI in light and dark to "What users see": the header chip and card (ready, conflicts, draft, merged), the sidebar marks and card, and the small-screen menu and dialog. They were captured from LibreChat dev (268ff45bf9) with the mock e2e harness, so they include #16860, #16882 and #16895. This replaces the screenshots TODO.
  • Brings that section in line with dev: the chip shows the title and opens its card below, the card's state badge includes Conflicts, merged is purple with no dot, and hovering a row opens its card.
  • Removes the Pending labels from the feature page, the agents reference and the .env reference, since #16987 to #16990 have merged, and documents sharedCacheSlots.

Change Type

  • Documentation update

Testing

  • pnpm typecheck, pnpm lint, prettier --check and pnpm build pass.
  • New e2e/pull-requests-guide.spec.ts: 5 scenarios, all passing against next start. They cover every image loading in its theme variant, the Conflicts badge, the icon and dot table, no Pending labels on the three pages, and sharedCacheSlots.
  • Checked all 16 captures by eye in light and dark.

Checklist

  • Behavior checked against LibreChat dev source (PullRequest/status.ts, Chip.tsx, RowMark.tsx, config.ts)
  • Only English pages edited; translations come from CI

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
librechat-ai Ready Ready Preview Oct 18, 2026 2:12pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T14:08:45.258112Z 03b4d91 New commits
🔒 Security Review ✅ Completed 2026-10-08T09:15:05.574260Z fb1461c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb1461cd85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread content/docs/features/pull_requests.mdx Outdated
Comment on lines +89 to +90
light="/images/pull-requests/mob-menu-light.png"
dark="/images/pull-requests/mob-menu-dark.png"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the obscured mobile-menu screenshots

Both mob-menu-light.png and mob-menu-dark.png show the menu and its PR #1234 entry at extremely low opacity, making the entry nearly indistinguishable from the background in either theme. Since this image is meant to show users where the small-screen pull-request control is located, recapture it without the dimming/transition overlay so the target menu item is readable.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8a3dbca. All screenshots were recaptured from current LibreChat dev with animations disabled, so the small-screen menu is fully opaque and the PR #1234 entry is readable in both themes. Verified by @Scenario:pull-request-screenshots-follow-the-reader-theme.

Comment thread content/docs/features/pull_requests.mdx Outdated
- The pull request number, with lines added in green and lines removed in red.
- A link that opens the pull request on GitHub.
- The pull request title.
- A **State** badge: Open, Draft, Merged or Closed.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the conflict state in the badge list

The newly added conflict screenshot directly below this section shows the card badge as State: Conflicts, but this list says the only possible state badges are Open, Draft, Merged, or Closed. This makes the guide contradict its own example for a normal merge-conflict scenario; include Conflicts and clarify that it is displayed instead of Open when the pull request cannot merge.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8a3dbca. The card section now lists Open, Conflicts, Draft, Merged or Closed, and notes that Conflicts replaces Open when an open pull request has merge conflicts, matching stateOf in PullRequest/status.ts. Verified by @Scenario:pull-request-card-names-the-conflicts-state.

Comment thread content/docs/features/pull_requests.mdx Outdated
### The status icon and dot

**Older versions:** `token` is required when the feature is enabled, and must be a `${NAME}` reference such as `"${GITHUB_PULL_REQUEST_TOKEN}"`. There is no environment variable fallback.
The icon color tells you if the pull request can merge. The dot next to it shows the state of the checks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Describe where the header status dot actually appears

When the chat agent has an avatar—as in every new header screenshot—the checks dot is overlaid on that avatar rather than placed next to the pull-request icon; the icon carries the dot only when no avatar is available. Saying the dot is next to the icon directs users to the wrong part of the chip in the common avatar case, so document this conditional placement.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8a3dbca. On current dev the header chip no longer has an avatar: Chip.tsx renders the pull request icon with the CI dot on its corner, then the title. The text now says that, and the avatar-era screenshots were replaced. Verified by @Scenario:pull-request-icon-table-matches-the-app.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for librechat.ai

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@berry-13
berry-13 force-pushed the docs/pull-requests-remove-pending branch from fb1461c to 8a3dbca Compare October 18, 2026 12:50
@berry-13 berry-13 changed the title 📖 docs: Make Conversation Pull Requests a User Guide With Screenshots 📸 docs: Add Current Pull Request Screenshots and Drop Released Pending Labels Oct 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for librechat.ai

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for librechat.ai

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

…Markers

Captures the chip, card, sidebar marks and small-screen menu and dialog from the current dev UI in light and dark, and corrects the user-facing text to match: the chip shows the title and opens its card below, merged is purple with no dot, the card's state badge includes Conflicts, and hovering a row opens its card. Bitbucket Cloud, per-user accounts and the shared cache have all merged, so their Pending labels go, and sharedCacheSlots is documented.
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for librechat.ai

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@berry-13
berry-13 merged commit 6c19a07 into main Oct 18, 2026
5 checks passed
@berry-13
berry-13 deleted the docs/pull-requests-remove-pending branch October 18, 2026 14:18

This branch was successfully deployed

1 active deployment
Preview — 03b4d913 Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant