Repository navigation
fix: accept bounded large egress grant headers - #331
Open
jacksonriding wants to merge 1 commit into
Open
jacksonriding wants to merge 1 commit into
jacksonriding wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed file grants can exceed Bun's default 16 KiB request-header limit when an execution has many input files. Those requests receive HTTP 431 before the gateway can validate the grant.
Set a finite 256 KiB header limit in the bundled gateway image, dedicated production/development images, and package startup script. The regression exercises the deployed command: a 32 KiB grant is accepted while a request above 256 KiB remains rejected. It also checks all four startup commands.
Validation on Bun 1.4.2:
docker buildx build --checkpasses for both changed Dockerfiles.The larger finite cap increases the maximum header bytes accepted per request.