Repository navigation
Node: fix get_transaction for transactions below the tip - #172
Merged
Merged
Conversation
torkelrogstad
changed the title
is_descendant was called with its arguments swapped, so only transactions in the tip block were found. deposit_withdraw_roundtrip now checks that a mined transfer stays findable as blocks build on it.
torkelrogstad
force-pushed
the
2026-10-04-get-tx
branch
from
October 5, 2026 09:19
34f35fa to
b31eee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_descendant was called with its arguments swapped, so only transactions
in the tip block were found. deposit_withdraw_roundtrip now checks that a
mined transfer stays findable as blocks build on it.