Repository navigation
broadcaster: say "last mined block", and show the chain tip beside it - #96
Merged
Merged
Conversation
"Last block: #970,851" was the newest block the POOL mined, but it read as the chain's height. With the network at 970,861 it looked like the pool's node had fallen ten blocks behind, or reorged. The line is now "Last mined block", and a "Chain tip" line above it gives the network's latest block as the pool's node sees it, by anyone, from /api/status's node.tip_height and tip_observed_at: Chain tip: #970,861 · 21m ago Last mined block: #970,851 · 3h 5m ago The tip line is left out while the dashboard has no node status yet. Both lines appear in the live message, the periodic update and /pool_status. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#95 added
Last block: #970,851to the snapshots. That was the newest block the pool mined, but it read as the chain's height. With the network at 970,861, an operator took it to mean the pool's node had fallen ten blocks behind or reorged. The node was in fact at the tip, matching the explorer and its peers.What
Last mined block. It is still the newest pending or confirmed block from/api/blocks.Chain tipline gives the network's latest block, mined by anyone, as the pool's node sees it. It comes from/api/status'snode.tip_heightandtip_observed_at, and is left out while the dashboard has no node status yet.Both lines appear in the live message, the periodic update and
/pool_status. Rendered from pool.beta.avonpool.xyz's live API:Tests
npm testinbroadcaster/: 34 pass. One test is new: the chain tip line appears with node status and is left out without it. The/pool_statustest now checks both lines in order, and the existing assertions use the new label.🤖 Generated with Claude Code