Repository navigation
fix(security): upgrade Jackson to 2.21.7 for TFS bug 712007 - #90
Open
dev-bot-laserfiche wants to merge 1 commit into
Open
dev-bot-laserfiche wants to merge 1 commit into
dev-bot-laserfiche wants to merge 1 commit into
Conversation
Bound polymorphic fallback type-ID caching through the patched 2.21 LTS release and cover distinct, repeated, and overlong IDs through the public mapper API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Contributor
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: Remediates CVE-2026-91776 tracked by TFS bug 712007 by raising the shared Jackson version from 2.21.6 to 2.21.7, the latest Maven Central patch in this repository's existing 2.21 LTS line. This updates jackson-databind and jackson-core together; jackson-annotations stays at its existing independently versioned 2.21 release.
The dependency is used directly by the library's JSON mappers and custom deserializers, so removing it is not appropriate. Although the built-in token models do not enable name-based polymorphic fallback, the public TokenClientObjectMapper.readValue(String, Class) API accepts caller-defined annotated models. A regression using that public API reproduced the finding on 2.21.6: 10,000 distinct unknown IDs retained 10,001 cache entries including a known subtype, while 10,000 repetitions of one unknown ID retained one entry.
The new regression passes on 2.21.7 and checks the cache never exceeds 1,000 entries in the sequential workload, fallback values remain correct, known subtypes still deserialize after cache churn, repeated IDs retain one entry, and overlong IDs are not retained. The changelog records the security patch. No lockfile exists in this Maven repository.
Verification used Java 8 and Maven 3.9.11:
mvn -B '-Dtest=com.laserfiche.api.client.unit.*Test,!com.laserfiche.api.client.unit.OAuthClientCredentialsHandlerTest,!com.laserfiche.api.client.unit.TokenClientUtilsTest' packagesucceeded: 44 tests, zero failures or errors, one existing skipped test; packaging and attached Javadoc/source/test jars also succeeded.mvn -B dependency:tree -Dincludes=com.fasterxml.jackson.core:*resolved jackson-databind and jackson-core exclusively to 2.21.7, with jackson-annotations 2.21.After human review and merge, rebuild/publish the library and run the next Veracode scan to clear the scanned component finding. This PR does not change publication configuration or the bug's state.
Work item links