Skip to content

Accessibility improvements: add text for empty links and buttons and alt text for images #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 2 commits into from
May 7, 2026
Merged

Accessibility improvements: add text for empty links and buttons and alt text for images #2983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1ca9b1
Update locator for product menu icon links
labkey-susanh May 6, 2026
3611e29
Merge remote-tracking branch 'origin/develop' into fb_emptyLinksAndBu…
labkey-susanh May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/org/labkey/test/components/ui/navigation/ProductMenu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,12 @@ protected class ElementCache extends Component<?>.ElementCache
private final WebElement folderColumn = Locator.tagWithClass("div", "col-folders").findWhenNeeded(menuContent);
private final WebElement sectionContent = Locator.tagWithClass("div", "sections-content").findWhenNeeded(menuContent);

public Locator.XPathLocator dashboardIconLoc = Locator.tagWithClass("i", "fa-home");
public Locator.XPathLocator dashboardIconLoc = Locator.tagWithClass("span", "fa-home");
public WebElement activeDashboardIcon = Locator.tagWithClass("div", "col-folders")
.descendant(Locator.tagWithClass("li", "active"))
.descendant(dashboardIconLoc)
.findWhenNeeded(menuContent);
public Locator.XPathLocator administrationIconLoc = Locator.tagWithClass("i", "fa-gear");
public Locator.XPathLocator administrationIconLoc = Locator.tagWithClass("span", "fa-gear");
public WebElement activeAdministrationIcon = Locator.tagWithClass("div", "col-folders")
.descendant(Locator.tagWithClass("li", "active"))
.descendant(administrationIconLoc)
Expand Down