Show protein context above precursor list in QC plots#1197
Merged
ankurjuneja merged 27 commits intorelease26.3-SNAPSHOTfrom May 6, 2026
Merged
Show protein context above precursor list in QC plots#1197ankurjuneja merged 27 commits intorelease26.3-SNAPSHOTfrom
ankurjuneja merged 27 commits intorelease26.3-SNAPSHOTfrom
Conversation
Contributor
Author
|
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Initial review looks good. A couple of questions/suggestions.
…y can be turned on and off
…t order - by precurson row id
… by precurson row id
… by precurson row id
Co-authored-by: Josh Eckels <jeckels@labkey.com>
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
One final request before merging which remains from my initial manual testing feedback in the issue:
Eliminate the narrow gap between the series labels when you're slowly mousing over them vertically, so that you move directly from one precursor to the next. It causes the list to flicker annoyingly. This is preexisting behavior.
labkey-jeckels
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1043
Related Pull Requests
Changes