Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b0ca7b8
Switch from GWT to React
labkey-jeckels Apr 25, 2026
ca99f5e
Auto code review and comments
labkey-jeckels Apr 25, 2026
a4b284f
Test fixes
labkey-jeckels Apr 25, 2026
0622405
Other cleanup
labkey-jeckels Apr 25, 2026
19e61e8
Improve generics for plate code
labkey-jeckels Apr 27, 2026
136e9f8
Merge branch 'refs/heads/develop' into fb_reactPlateDesigner
labkey-jeckels Apr 28, 2026
a912417
Unit tests and other improvements
labkey-jeckels Apr 28, 2026
6851d9c
Another checkpoint
labkey-jeckels Apr 28, 2026
6eea87a
Merge branch 'develop' into fb_reactPlateDesigner
labkey-jeckels Apr 29, 2026
28daef7
Code review improvements, generics updates
labkey-jeckels Apr 29, 2026
82f1f83
Unit test fixup, bounds validation
labkey-jeckels Apr 29, 2026
507c281
Merge branch 'develop' into fb_reactPlateDesigner
labkey-jeckels Apr 29, 2026
3cdf006
Manual test and code review feedback
labkey-jeckels Apr 30, 2026
72b7ae4
Don't warn on intentional navigation away from a dirty page
labkey-jeckels May 2, 2026
70c1908
Update assay/src/client/PlateTemplateDesigner/components/GroupTypesPa…
labkey-jeckels May 4, 2026
37b97d4
Update assay/src/client/PlateTemplateDesigner/components/ShiftPanel.tsx
labkey-jeckels May 4, 2026
a346db8
Update assay/src/client/PlateTemplateDesigner/components/WarningPanel…
labkey-jeckels May 4, 2026
f3374d6
Merge branch 'refs/heads/develop' into fb_reactPlateDesigner
labkey-jeckels May 4, 2026
861dbc9
Checkpoint
labkey-jeckels May 5, 2026
03b3dec
Address code review suggestions. A little more accessibilty improvement
labkey-jeckels May 5, 2026
1e4666f
Add eslint-config dependency to assay package
labkey-alan May 5, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assay/api-src/org/labkey/api/assay/plate/Plate.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ public interface Plate extends PropertySet, Identifiable

@Nullable WellGroup getWellGroup(int rowId);

@NotNull List<WellGroup> getWellGroups();
@NotNull List<? extends WellGroup> getWellGroups();

@NotNull List<WellGroup> getWellGroups(Position position);
@NotNull List<? extends WellGroup> getWellGroups(Position position);

@NotNull List<WellGroup> getWellGroups(WellGroup.Type type);
@NotNull List<? extends WellGroup> getWellGroups(WellGroup.Type type);

@NotNull Map<WellGroup.Type, Map<String, WellGroup>> getWellGroupMap();

Expand Down
2 changes: 1 addition & 1 deletion assay/api-src/org/labkey/api/assay/plate/PlateService.java
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ static PlateService get()
*/
@Nullable Plate getPlate(ContainerFilter cf, Long plateSetId, Object plateIdentifier);

@NotNull List<Plate> getPlates(Container container);
@NotNull List<? extends Plate> getPlates(Container container);

/**
* Gets the plate set by ID
Expand Down
2 changes: 1 addition & 1 deletion assay/api-src/org/labkey/api/assay/plate/PlateSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public interface PlateSet extends Identifiable

boolean isTemplate();

List<Plate> getPlates();
List<? extends Plate> getPlates();

PlateSetType getType();

Expand Down
2 changes: 2 additions & 0 deletions assay/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
import config from '@labkey/eslint-config';
export default config;
Loading
Loading