Disable Id on Exam forms when case created.#1707
Open
labkey-martyp wants to merge 7 commits intorelease25.11-SNAPSHOTfrom
Open
Disable Id on Exam forms when case created.#1707labkey-martyp wants to merge 7 commits intorelease25.11-SNAPSHOTfrom
labkey-martyp wants to merge 7 commits intorelease25.11-SNAPSHOTfrom
Conversation
labkey-bpatel
previously approved these changes
May 4, 2026
Contributor
labkey-bpatel
left a comment
labkey-bpatel
left a comment
There was a problem hiding this comment.
Looks good, please review my comment.
| var rec = EHR.DataEntryUtils.getBoundRecord(field); | ||
| var readOnly = !!(rec && rec.get('caseid')); | ||
| field.setReadOnly(readOnly); | ||
| setTooltip(readOnly); |
Contributor
There was a problem hiding this comment.
Does it make sense to gray out the disabled Id? so that it doesn't look like it is available for updating - just a little better visually/user experience, imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Ticket 54568: Exams/Cases allows creation of observation linked to another animal's case.
This PR disables the Animal Id data entry field in the SOAP (clinremarks) section of Exams/Cases and BSU Exam when a case is created. When a case is created the caseid is attached to all records in the form. The only way to change the Id in the forms (which could cause multiple Ids on the same case) is via the SOAP section Id, so disabling it when a case is associated with the records ensures no other Ids can be entered for the case.
Changes