Accessibility Improvements: App Colors#1993
Merged
Conversation
labkey-susanh
approved these changes
May 4, 2026
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
I like that we've got more consistency with this and some more mnemonic variable names. I would still love to get rid of at least one of gray-light and light-gray. Complete tossup for which variable to use when. But that will be for another time.
| $brand-secondary: #116596; | ||
| $brand-danger: #D43F3A; | ||
| $brand-warning: #f0ad4e; | ||
| $brand-success: #5AA54A; |
Contributor
There was a problem hiding this comment.
This change means some of the color updates will happen in the domain designers in LKS, right? Anywhere else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR updates the color system in @labkey/components for accessibility: it introduces semantic color tokens ($text-color-light, $link-color, alert variables), updates brand/state colors to more accessible values,
consolidates hardcoded color strings to variables, and migrates several component buttons from btn-info to btn-primary or btn-success.
Related Pull Requests
Changes
#2980B9change to#0F72C2#777and$gray-lightto$text-color-light$text-color-lightand$gray-darkfor hover#2980B9change to#0F72C2$badge-colorto#D43F3A#5CB85Cchange to#5AA54A($brand-success)$brand- colorvariables