Let print_timer() print a Section - #239
Open
johnomotani wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
===========================================
+ Coverage 84.82% 94.93% +10.10%
===========================================
Files 5 9 +4
Lines 323 948 +625
===========================================
+ Hits 274 900 +626
+ Misses 49 48 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Could maybe use a test |
Author
What kind of test is appropriate? Just something that calls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
print_timer()to printSectionas well asTimerOutput.The 1.0 update (I guess) meant that
to["foo"]is aSection, not aTimerOutput. This meant thatprint_timer(to["foo"])errored. It would be possible to work around this by callingshow_table()directly, butprint_timer()is part of the public API andshow_table()is not, so this looks like a bug. To reproduce (or see that it is fixed with this PR):