gensym the closure name in @timeit_debug function bodies - #232
Open
KristofferC wants to merge 1 commit into
Open
gensym the closure name in @timeit_debug function bodies#232KristofferC wants to merge 1 commit into
KristofferC wants to merge 1 commit into
Conversation
The closure was literally named `inner` and lands in the user's scope, so a body calling a global `inner` got a MethodError and an argument named `inner` was a syntax error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closure
@timeit_debugwraps a function body in is literally namedinner, and the wrapper is escaped into the user's function, soinnerbecomes a local binding in their scope:The first fails at run time, the second at definition time. Both happen whether or not debug timings are enabled, since the closure is emitted either way.
@gensymthe name so it can't clash.Independent of #230, though that PR is why I noticed — it removes the reason to extend this closure to plain
@timeit.