Conversation
daker
force-pushed
the
webgpu-shared-gpudevice
branch
from
September 13, 2026 01:15
3f9670e to
9046596
Compare
daker
changed the title
daker
force-pushed
the
webgpu-shared-gpudevice
branch
2 times, most recently
from
September 13, 2026 01:26
163233b to
22791dc
Compare
Collaborator
Author
daker
force-pushed
the
webgpu-shared-gpudevice
branch
from
September 13, 2026 01:30
22791dc to
f8d1203
Compare
PaulHax
reviewed
Sep 13, 2026
PaulHax
reviewed
Sep 13, 2026
PaulHax
reviewed
Sep 13, 2026
PaulHax
left a comment
PaulHax
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for pushing on this. I don't have a project using WebGPU (at the moment) so I'm not really in a good position to give good feedback on this important foundational work.
daker
force-pushed
the
webgpu-shared-gpudevice
branch
from
September 13, 2026 20:38
f8d1203 to
b02066f
Compare
Collaborator
Author
|
@finetjul can i get a review on this one when you have time ? |
Member
sankhesh
requested changes
Sep 18, 2026
Collaborator
|
Several windows now share one vtkWebGPUDevice (pipelines, shader and buffer/texture caches). No cache is released or reference-counted when one window releases. Please confirm that a window's |
daker
force-pushed
the
webgpu-shared-gpudevice
branch
from
September 19, 2026 22:49
b02066f to
db5d889
Compare
Collaborator
Author
|
@sankhesh i have addressed your concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3648
Results
Changes
PR Checklist