Skip to content

Keep a detection's box corners editable while editing its line - #1932

Merged
BryonLewis merged 8 commits into
mainfrom
dev/edit-box-in-line-mode
Sep 21, 2026
Merged

BryonLewis merged 8 commits into
mainfrom
dev/edit-box-in-line-mode

Conversation

@mattdawkins

Copy link
Copy Markdown
Member
  • In line editing mode, when the detection also has a box and boxes are visible, the box corners get drag handles too, so the auto-generated box can be adjusted without leaving line mode.
  • Implemented as a second EditAnnotationLayer (companion: true, corner handles only) that is live whenever the selected track has both a saved line at the selected key and bounds; it stays off while the line is still being drawn.
  • GeoJS applies a handle drag to every annotation layer in edit mode, so each layer records at actiondown whether its own handle was grabbed and only that one moves and commits. A box commit does not rebuild the line layer, and a hovered handle's drag action is restored after the peer layer changes mode.
  • Covered by a real-GeoJS jsdom spec that drags a box corner and a line vertex with the other layer's handle previously hovered.

🤖 Generated with Claude Code

mattdawkins and others added 3 commits September 17, 2026 21:26
Keep companion/peer edit-layer tests alongside main's deferred
changeData cursor and rehover handle coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>
@BryonLewis
BryonLewis self-requested a review September 21, 2026 19:46
BryonLewis
BryonLewis previously approved these changes Sep 21, 2026

@BryonLewis BryonLewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fixed some minor issue that could clear out creation actions.

@BryonLewis
BryonLewis merged commit aaf66eb into main Sep 21, 2026
3 checks passed
@BryonLewis
BryonLewis deleted the dev/edit-box-in-line-mode branch September 21, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants