fix(processing): refetch a job's details once it finishes - #958
Merged
Merged
Conversation
Opening a running job's details cached the log as it was at that moment, so a job that then failed kept showing a traceback cut off before the error line until VolView was reloaded. Record whether each detail request was issued before the job finished. When the provider reports the job terminal, drop a detail fetched earlier and fetch it again. Only the latest request's response is kept, so a slow earlier response cannot replace the final log. Rows that were never opened and synthesized failures fetch nothing.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a job's Details in the Jobs panel fetches its log once and caches it. If the job was still running at that moment and then failed, the error box kept showing the log as it was when the row was expanded, often a traceback cut off before the line naming the error. Collapsing and re-expanding the row did not help; only reloading VolView did.
Change
errorTail.registerFake,jobStatus) move intofakeProvider.ts.