Fix/slicing and remap - #139
Merged
Merged
Conversation
SetSlicing stores each valid dimension's index and records it as changed, then skipped Modified() entirely if any *other* dimension in the same request was out of range. Since the caller resends the whole slicing dict every time, one stale index suppressed every later change: the reader's state moved but its output never did. The app triggered exactly that by seeding any time slider to index 50, which is past the end of most files (11 steps here, 12 for ne4pg2, 25 for ne30pg2). With it stuck there, moving the level slider did nothing -- and cropping appeared to "fix" it, because that forced a pipeline pass which picked up the pending values. Mark modified when a valid slice changed, and clamp the seeded slider index to the dimension.
add_cell_arrays walked the pedigree permutation as a list of monotonic run slices, on the assumption that the runs were thousands of entries long. The permutations this pipeline actually produces average 55-110 entries per run, and at that length the per-run Python overhead dominates: the loop measures 8-16x slower than a single fancy-index gather. Replaces it with in_np[pid_np] and drops the plan cache. Roughly 10-15% off each pipeline pass with a crop active.
Collaborator
Author
|
@jourdain can you review? |
jourdain
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.