De-generic executor and refactor ORM stack#349
Open
KKould wants to merge 17 commits into
Open
Conversation
Remove the transaction type parameter from executor nodes and route execution state through a runtime trait so executor code is compiled once instead of monomorphized per storage backend.
44e2d3f to
2d22d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch reduces compile-time pressure in the execution layer by de-genericizing executor nodes. The executor no longer carries the transaction/storage type parameter through every node; instead, shared execution state is routed through a runtime trait, so executor node code can be compiled once instead of being monomorphized per storage backend.
Key changes:
Binary Size Comparison
Measured as stripped release binaries on
x86_64-unknown-linux-gnuwithrustc 1.88.0. The KiteSQL binary is a small ORM/typed API smoke example that creates a table, inserts two rows, fetches them, and drops the table.Important: the PR measurements intentionally do not enable the
parserfeature.mainstill has parser/sqlparser as a non-optional dependency, so main cannot be measured with the same no-parser feature set.c0e63a0memoryorm,macros; parser not feature-gated on main4ee5c66memoryorm; parser disabledc0e63a0RocksDBorm,macros,rocksdb; parser not feature-gated on main4ee5c66RocksDBorm,rocksdb; parser disabledc0e63a0LMDBorm,macros,lmdb; parser not feature-gated on main4ee5c66LMDBorm,lmdb; parser disabled0.34.0+ bundled SQLite2.0.0-rc.382.3.10+ bundled SQLite0.7.0-pre.7and pinned0.5.0did not compile on this rustc due transitive/proc-macro API requirementsKiteSQL PR reduction vs main in this measurement:
TPCC Throughput Comparison
Measured on the current PR branch at
192c5c9with./scripts/run_tpcc_matrix.shafter removing old TPCC database state. The runner uses 1 warehouse, TPCC default 720s measurement windows, and removes each backend database path before running the variant. Raw logs were generated locally during the run and are not committed. Note: this is a single local long-window run; follow-up same-machine 120s checks did not reproduce a large regression at65a57bf, so these TPCC numbers should be treated as preliminary until rerun under a controlled benchmark state.Testing
cargo test --workspacemake wasm-build && make wasm-examples