Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Unmatched contours currently shrink almost immediately under polar interpolation. Add
contourTransition: MorphContourTransition.lineartoMorphIcon,AnimatedMorphIcon, andprecacheMorphso appearing/disappearing contours change size linearly with morph progress. Unmatched contours clamp spring overshoot at their endpoints.MorphContourTransition.legacyremains the default and preserves existing visuals. Cache keys include the policy. Changing the policy during an implicit transition replans from the visible shape; pending old results cannot replace the new plan, and changing policy while idle preserves the settled frame.The existing playground
Curves.linearchoice controls progress over time; the newLinear sizeswitch controls unmatched-contour shape at a given progress and is available in both spring and manual modes. Generated playground code reflects both choices. This is the first, opt-in step toward better motion. Matched-contour rotation and correspondence are unchanged; it does not solve the semanticmenu → closetrajectory. The new mode was visually inspected and is not a universal replacement for legacy motion.Dependency
Stacked on #18 to integrate the option with precaching. This PR targets
codex/morph-performance-precacheso its diff contains only the motion configuration change. Retarget to main after #18 merges.Validation
361f54dpixel-for-pixel. Another 108 captures exercise the opt-in mode; side-by-side inspection confirms gradual hole closure and dot disappearance.Capture opt-in visuals with
--dart-define=VISUAL_LINEAR=truewhen runningtool/visual_ab_test.dart.