cmake: add logic to download ffmpeg for win32 - #190
Merged
Conversation
crmurillo
force-pushed
the
ffmpeg_win32_download
branch
3 times, most recently
from
April 6, 2026 13:16
c78d419 to
2ae4448
Compare
crmurillo
marked this pull request as ready for review
April 7, 2026 08:38
dabrain34
requested changes
Apr 9, 2026
crmurillo
force-pushed
the
ffmpeg_win32_download
branch
3 times, most recently
from
April 21, 2026 14:44
e93e08b to
1e1c21f
Compare
crmurillo
force-pushed
the
ffmpeg_win32_download
branch
from
September 9, 2026 20:17
1e1c21f to
fa9e96f
Compare
dabrain34
requested changes
Sep 10, 2026
Download FFmpeg shared libraries for Windows if they are not already present. Pre-built LGPL binaries are fetched from BtbN/FFmpeg-Builds for win64 and winarm64 platfoms. Downloads are verified against published SHA256 checksums. The automatic download can be disabled with -DDOWNLOAD_FFMPEG=OFF.
crmurillo
force-pushed
the
ffmpeg_win32_download
branch
from
September 10, 2026 11:28
fa9e96f to
add2bd8
Compare
dabrain34
reviewed
Sep 10, 2026
dabrain34
requested changes
Sep 10, 2026
-Removed step to download FFmpeg for Windows since this is now handled by cmake. -Downloading FFmpeg is enabled by default for 64-bit builds except for the new job windows-x64-without-ffmpeg. -Disabled FFmpeg download for 32-bit Windows builds: pre-built 32-bit FFmpeg libraries are not available from BtbN/FFmpeg-Builds.
crmurillo
force-pushed
the
ffmpeg_win32_download
branch
from
September 11, 2026 09:24
add2bd8 to
ebabe88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, using FFmpeg on Windows requires manual installation.
This patch adds a cmake module that downloads FFmpeg shared libraries for Windows when they are not already present. Pre-built LGPL binaries are fetched from BtbN/FFmpeg-Builds for win64 and winarm64 platforms, and verified against published SHA256 checksums.
The automatic download can be disabled with
-DDOWNLOAD_FFMPEG=OFF.Type of change
feature
Tests
AMD Radeon RX 6600 (1002:73ff) / AMD proprietary driver 26.8.1 (AMD proprietary shader compiler) / Windows 10
Total Tests: 88
Passed: 37
Crashed: 7
Failed: 2
Not Supported: 42
Success Rate: 80.4%
Intel(R) UHD Graphics 770 (ADL-S GT1) (8086:4680) / Intel open-source Mesa driver Mesa 26.3.0-devel (git-fe1491b758) / Ubuntu 24.04.4 LTS
Total Tests: 85
Passed: 57
Crashed: 0
Failed: 0
Not Supported: 25
Skipped: 3 (in skip list)
Success Rate: 100.0%
AMD Radeon RX 7600 (RADV NAVI33) (1002:7480) / radv Mesa 26.3.0-devel (git-fe1491b758) / Ubuntu 24.04.4 LTS
Total Tests: 85
Passed: 69
Crashed: 0
Failed: 0
Not Supported: 12
Skipped: 4 (in skip list)
Success Rate: 100.0%
Additional Details (optional)
For AMD proprietary driver for Windows, 7 tests crash and 2 fail, same behavior as with the main branch.