Install NNEF-Tools parser headers alongside the sample impl#72
Merged
Conversation
Add an install(DIRECTORY) rule for kernels/NNEF-Tools/parser/cpp/include/ so that cnnef.h and the nnef/ headers are installed into the include directory alongside the OpenVX headers. This allows downstream consumers (e.g. the CTS) to find them via OPENVX_INCLUDES without needing a separate -I pointing into the sample impl source tree. Co-Authored-By: Claude <noreply@anthropic.com>
CMAKE_INSTALL_INCLUDEDIR is empty because GNUInstallDirs is not included in this project; use the literal 'include' to match the pattern used by the rest of the sample impl. Co-Authored-By: Claude <noreply@anthropic.com>
The spec declares vx_event_t.user_event_parameter as void* but vxSendUserEvent takes const void*. Cast to void* on assignment to match the spec-defined field type. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cnnef.hand thennef/headers fromkernels/NNEF-Tools/parser/cpp/include/are used directly by CTS test sources (test_nnef_import.c) but were not installed bymake install-Ipointing into the sample impl source tree to find theminstall(DIRECTORY)rule so the headers land in$OPENVX_DIR/include/alongside the OpenVX headers — reachable via the standardOPENVX_INCLUDESpathTest plan
-DOPENVX_CONFORMANCE_NNEF_IMPORT=ONandmake installcnnef.happears under$OPENVX_DIR/include/-Iflag — should compile cleanly🤖 Generated with Claude Code