Fix unclosed brace in vxExecuteGraph when streaming is disabled#70
Merged
Conversation
… defined The streaming commit (#69) introduced a while loop guarded by #ifdef OPENVX_USE_STREAMING, with a bare { in the #else path as a drop-in replacement. The } closing the while body was inside the #ifdef block, leaving the bare { in the non-streaming path unclosed. This caused a compile error at end-of-file for any build without -DOPENVX_USE_STREAMING=ON. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whileloop inside#ifdef OPENVX_USE_STREAMINGinvxExecuteGraph, with a bare{in the#elsepath as a drop-in replacement}closing thewhilebody was inside the#ifdefblock, leaving the bare{in the non-streaming path unclosed-DOPENVX_USE_STREAMING=ONfailed at end-of-file with:error: expected declaration or statement at end of inputFix
Adds
#else/}to close the bare block in the non-streaming path, matching the}that closes thewhilebody in the streaming path.Test plan
-DOPENVX_USE_STREAMING=ON— should continue to compile and pass conformance🤖 Generated with Claude Code