Repository navigation
Follow-up to #228: CI for the MSVC pkg-config fallback; one shared pkg-config probe - #229
Merged
Merged
Conversation
dginev
force-pushed
the
followup/pkgconfig-msvc
branch
from
November 6, 2026 17:49
28eb2da to
e3f70f6
Compare
…onfig No vcpkg, as in conda-forge's own builds, so build.rs takes the pkg-config fallback; a last step checks that it did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The MSVC fallback now honours LIBXML2_STATIC as the Unix branch does, and vcpkg's error is printed instead of discarded, next to pkg-config's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t works Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dginev
force-pushed
the
followup/pkgconfig-msvc
branch
from
November 6, 2026 17:51
e3f70f6 to
e9898f6
Compare
This was referenced Nov 6, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #228.
Windows MSVC pkg-config (conda-forge). It installslibxml2-develandpkg-configfrom conda-forge with no vcpkg, runscargo test, then checks the build script's stderr to confirm the fallback was taken.mainplus this job fails withCould not find libxml2.(run)pkg_config_find_libxml2()serves both Unix and the MSVC fallback, so the fallback also honoursLIBXML2_STATIC. No CI covers a static MSVC build.vcpkg_find_libxml2now returns vcpkg's error, and the build prints it next to pkg-config's.pkg-config >= 0.3.14, the first release whose MSVC support works according to its CHANGELOG. The build works with 0.3.14.VCPKGRS_DISABLE=1skips vcpkg.🤖 Generated with Claude Code