Skip to content

Add note about RLZoo deprecation - #1062

Open
jeremiahpslewis wants to merge 1 commit into
mainfrom
jpsl/rlzoo-note
Open

Add note about RLZoo deprecation#1062
jeremiahpslewis wants to merge 1 commit into
mainfrom
jpsl/rlzoo-note

Conversation

@jeremiahpslewis

Copy link
Copy Markdown
Member

PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

@codecov

codecov Bot commented Mar 26, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 1.12%. Comparing base (d470d48) to head (1684215).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #1062       +/-   ##
==========================================
- Coverage   32.35%   1.12%   -31.23%     
==========================================
  Files          73      73               
  Lines        2785    2748       -37     
==========================================
- Hits          901      31      -870     
- Misses       1884    2717      +833     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenriDeh HenriDeh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add an @warn in the __init__ method of the package. This way users will be warned when loading it.

@jeremiahpslewis

Copy link
Copy Markdown
Member Author

@HenriDeh What about an @info when loading RL.jl?

@HenriDeh

Copy link
Copy Markdown
Member

That also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants