Repository navigation
Fix eltype for FatMachOHandle - #59
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 69.94% 69.93% -0.01%
==========================================
Files 46 46
Lines 1364 1367 +3
==========================================
+ Hits 954 956 +2
- Misses 410 411 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
topolarity
force-pushed
the
ct/fix-fat-macho-eltype
branch
from
October 8, 2026 16:02
474451f to
03fbe67
Compare
Fat files with `FAT_MAGIC_64` could not be read at all: - `macho_endianness()` did not know `FAT_MAGIC_64` / `FAT_CIGAM_64`, so `readmeta()` threw a `MagicMismatch` for them. - `MachOFatArch64` declared `cputype` and `cpusubtype` as `UInt64`, but in `fat_arch_64` they are 32-bit, as in `fat_arch`. This shifted every following field, so slice offsets were wrong. Add a `libfoo_fat64.dylib` test fixture, made from the slices of `libfoo_fat.dylib` with `llvm-lipo -create -fat64` (LLVM 18). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`position()` of an `IOBuffer` is an `Int`, which on 32-bit platforms does not match the `Int64` start of a `FatMachOHandle`. Convert it, as the other handle types already do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
topolarity
force-pushed
the
ct/fix-fat-macho-eltype
branch
from
October 9, 2026 13:47
03fbe67 to
40443fe
Compare
Collaborator
Author
|
Merging this as a straightforward bug fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JuliaPackaging/BinaryBuilder.jl#1426.