Skip to content

KI Sub-groups#668

Open
christiangnrd wants to merge 9 commits into
JuliaGPU:mainfrom
christiangnrd:subgroups
Open

KI Sub-groups#668
christiangnrd wants to merge 9 commits into
JuliaGPU:mainfrom
christiangnrd:subgroups

Conversation

@christiangnrd

@christiangnrd christiangnrd commented Dec 23, 2025

Copy link
Copy Markdown
Member

Includes #682

@github-actions

github-actions Bot commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@christiangnrd christiangnrd mentioned this pull request Jan 2, 2026
@christiangnrd christiangnrd marked this pull request as draft January 3, 2026 19:47
Comment thread test/intrinsics.jl
@christiangnrd christiangnrd force-pushed the subgroups branch 7 times, most recently from daea025 to 6343fd2 Compare January 7, 2026 16:55
@codecov

codecov Bot commented Jan 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.78%. Comparing base (cb7049f) to head (56c597e).

Files with missing lines Patch % Lines
src/pocl/backend.jl 76.92% 6 Missing ⚠️
src/intrinsics.jl 0.00% 3 Missing ⚠️
src/pocl/compiler/compilation.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #668       +/-   ##
===========================================
+ Coverage   52.05%   62.78%   +10.72%     
===========================================
  Files          23       23               
  Lines        1921     1967       +46     
===========================================
+ Hits         1000     1235      +235     
+ Misses        921      732      -189     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christiangnrd christiangnrd force-pushed the subgroups branch 5 times, most recently from f0a545c to 8858825 Compare February 19, 2026 23:54
@christiangnrd christiangnrd marked this pull request as ready for review February 20, 2026 00:13
@christiangnrd christiangnrd force-pushed the subgroups branch 3 times, most recently from 7ddba7e to 8de2c42 Compare March 24, 2026 10:29
@JuliaGPU JuliaGPU deleted a comment from github-actions Bot Mar 24, 2026
@christiangnrd christiangnrd force-pushed the subgroups branch 2 times, most recently from 409a1e7 to 08a8130 Compare May 28, 2026 22:53
@christiangnrd christiangnrd force-pushed the subgroups branch 5 times, most recently from b1d526f to 2f02082 Compare June 4, 2026 18:00
@christiangnrd

This comment was marked as resolved.

@christiangnrd

Copy link
Copy Markdown
Member Author

@maleadt @vchuravy This is ready for final review. If/once accepted I’ll merge the backend subgroup branches into their respective ka 0.10 branch and undo the new branch redirection before merging this one

@maleadt

maleadt commented Jun 17, 2026

Copy link
Copy Markdown
Member

I think the ideal solution would be to have get_num_sub_groups always return at least 1 so we can force a sub-group size.

FWIW, I fixed that, and pocl_jll should include the patch merged upstream to make get_num_sub_groups behave sensibly.

@christiangnrd

Copy link
Copy Markdown
Member Author

FWIW, I fixed that, and pocl_jll should include the patch merged upstream to make get_num_sub_groups behave sensibly.

I never got around to removing setting the subgroup size by default so no changes necessary.

Also, I bumped the required pocl_standalone_jll to 7.1.3, could/should we yank 7.1.3+0 to guarantee no segfaults from libpocl mismatches?

@christiangnrd christiangnrd added this to the 0.10.0 milestone Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants