Skip to content

Turn Julia passes into closures#864

Merged
maleadt merged 2 commits into
mainfrom
vc/current_job
Jun 29, 2026
Merged

Turn Julia passes into closures#864
maleadt merged 2 commits into
mainfrom
vc/current_job

Conversation

@vchuravy

Copy link
Copy Markdown
Member

I was thinking about current_job and if we could replace it,
and I think if we turn our passes into manual closures then we could pass it in, instead of relying on a global variable.

@maleadt

maleadt commented Jun 28, 2026

Copy link
Copy Markdown
Member

Oh, that's cute! And would have avoided bugs like the one fixed in #855.
I've made Claude apply it to the other passes.

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.40659% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.78%. Comparing base (03ae9a5) to head (ecf6fee).

Files with missing lines Patch % Lines
src/driver.jl 83.33% 3 Missing ⚠️
src/optim.jl 93.61% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   80.12%   79.78%   -0.34%     
==========================================
  Files          25       25              
  Lines        4775     4760      -15     
==========================================
- Hits         3826     3798      -28     
- Misses        949      962      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt

maleadt commented Jun 29, 2026

Copy link
Copy Markdown
Member

Nightly failure unrelated.

@maleadt maleadt merged commit 04e9aa9 into main Jun 29, 2026
32 of 37 checks passed
@maleadt maleadt deleted the vc/current_job branch June 29, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants