Reduce testsuite runtime by merging similar reduction testsets#728
Merged
Conversation
Member
Author
|
Test failures unrelated |
Member
Author
|
Bump. This should be fairly simple to review |
616a05e to
5e163b4
Compare
5e163b4 to
78f9a90
Compare
Member
Author
|
This is just moving tests around so I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge mapreducedim! and reducedim! testsets.
Also merge mapreduce and reduce testsets while factoring out the
&,|, andxortests to keep Alloc values reasonable.The result is that 4 testsets that used to take well over a minute each are now 2 testsets that take a few seconds longer than the longest of the 2 and a shorter ~30s testset.
Probably not a huge difference tests are mostly run in parallel, but this feels like a huge amount of time that used to be wasted compiling kernels instead of actually testing.
Timing comparison
Command:
using Pkg; Pkg.test("CUDA|Metal"; test_args=["--jobs=1", "--verbose", "gpuarrays/reductions/mapred", "gpuarrays/reductions/and", "gpuarrays/reductions/red"])*I also forced a new worker for every test in runtest.jl's
test_workerto ensure worst-case scenario