Skip to content

Minor tidy: use peel rather than [1] and drop#483

Merged
oxinabox merged 1 commit into
masterfrom
ox/peelnotdrop
Oct 8, 2021
Merged

Minor tidy: use peel rather than [1] and drop#483
oxinabox merged 1 commit into
masterfrom
ox/peelnotdrop

Conversation

@oxinabox

@oxinabox oxinabox commented Oct 8, 2021

Copy link
Copy Markdown
Member

Very small change as a follow up to something changed in #482
Since we want the head and the tail, we can use Iterators.peel

@mzgubic mzgubic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version bump and it's good to fly

@oxinabox

oxinabox commented Oct 8, 2021

Copy link
Copy Markdown
Member Author

version bump and it's good to fly

It is a nonfunctional change.

@oxinabox oxinabox merged commit 695dd77 into master Oct 8, 2021
@oxinabox oxinabox deleted the ox/peelnotdrop branch October 8, 2021 12:20
@mzgubic

mzgubic commented Oct 8, 2021

Copy link
Copy Markdown
Member

Sure, but it could inadvertently introduce a bug. My understanding was that any change to code src/ should bump a version?

@oxinabox

oxinabox commented Oct 8, 2021

Copy link
Copy Markdown
Member Author

For small nonfunctional changes I am ambivalent. We've run tests and reverse dep tests.
For bigger refactorings I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants