test(utils): Enhance unit test coverage for getViewerLocalHour with invalid date strings - #9031
Open
Rakshak05 wants to merge 1 commit into
Open
test(utils): Enhance unit test coverage for getViewerLocalHour with invalid date strings#9031Rakshak05 wants to merge 1 commit into
Rakshak05 wants to merge 1 commit into
Conversation
Contributor
|
@Rakshak05 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR adds significant unit test coverage for the |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
approved these changes
Aug 16, 2026
Aamod007
left a comment
Collaborator
There was a problem hiding this comment.
Solid set of edge case tests! The extra type guard on \isoDate\ is a great small addition for runtime safety. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8633
This PR adds comprehensive unit test coverage for the
getViewerLocalHourutility function inutils/dateHelpers.ts.Changes Included:
+02:00,-05:00,Z).2024-03-10,2024-03).'').invalid-date,2024-03-XX,hello world).2024-03-10T,2024-13-99T25:99:00).-9999999-01-01).999999999-01-01).null,undefined).getViewerLocalHour(typeof isoDate !== 'string') for added runtime safety.0to23).Pillar
Visual Preview
N/A (Unit test coverage expansion)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.