Skip to content

Fixed a small memory leak in acceptAcceptor - #6740

Merged
coot merged 2 commits into
masterfrom
coot/trace-acceptor-memory-leak
Oct 26, 2026
Merged

coot merged 2 commits into
masterfrom
coot/trace-acceptor-memory-leak

Conversation

@coot

@coot coot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Description

Fixed a small memory leak in acceptAcceptor.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@coot
coot requested a review from a team as a code owner October 20, 2026 16:08

@mgmeier mgmeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @coot !
RFC is regarding cabal version bump + changelog entry.

@mgmeier
mgmeier enabled auto-merge October 20, 2026 16:55
@mgmeier
mgmeier requested review from a team as code owners October 20, 2026 17:17
@mgmeier
mgmeier force-pushed the coot/trace-acceptor-memory-leak branch from 02cfcf3 to 602892f Compare October 20, 2026 19:22
@mgmeier
mgmeier added this pull request to the merge queue Oct 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 20, 2026
@mgmeier
mgmeier added this pull request to the merge queue Oct 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 20, 2026
@mgmeier
mgmeier added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 21, 2026
@coot
coot added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026
@mgmeier
mgmeier added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026
@mgmeier
mgmeier force-pushed the coot/trace-acceptor-memory-leak branch from 602892f to 5b6354a Compare October 21, 2026 17:12
@coot
coot enabled auto-merge October 26, 2026 17:20
@coot
coot disabled auto-merge October 26, 2026 17:20
@coot
coot enabled auto-merge October 26, 2026 17:20
@koslambrou
koslambrou force-pushed the coot/trace-acceptor-memory-leak branch from 5b6354a to e5c1e84 Compare October 26, 2026 17:34
@coot
coot added this pull request to the merge queue Oct 26, 2026
Merged via the queue into master with commit 89d1acc Oct 26, 2026
31 checks passed
@coot
coot deleted the coot/trace-acceptor-memory-leak branch October 26, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants