Skip to content

Fix: Bisect: 1f0a9dd | Windows Silent Failures#1611

Merged
xsscx merged 1 commit into
masterfrom
ci-fix-tiff-regression
Jun 30, 2026
Merged

Fix: Bisect: 1f0a9dd | Windows Silent Failures#1611
xsscx merged 1 commit into
masterfrom
ci-fix-tiff-regression

Conversation

@xsscx

@xsscx xsscx commented Jun 30, 2026

Copy link
Copy Markdown
Member

PR Summary

2026-06-30 00:28:47 UTC

Resolved #1610

PS C:\tmp\fix\iccDEV>  cd C:\tmp\fix\iccDEV\Testing\hybrid; mkdir ICC,Results,config -Force; iccFromXml MultSpectralRGB.xml ICC\MultSpectralRGB.icc; iccApplyProfiles -exportcfg config\makeMS_smCows.json Data\smCows380_5_780.tif Results\MS_smCows.tif 2 1 0 1 1 -embedded 3 ICC\MultSpectralRGB.icc 10003; iccTiffDump Results\MS_smCows.tif


    Directory: C:\tmp\fix\iccDEV\Testing\hybrid


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----         6/29/2026   5:08 PM                ICC
d-----         6/29/2026   5:08 PM                Results
d-----         6/29/2026   5:06 PM                config
Profile parsed and saved correctly

TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
100%
-------------------->Tiff Image Dump<---------------------------
Filename:          Results\MS_smCows.tif
Size:              (600 x 420) pixels, (8.33" x 5.83")
Planar:            Interleaved samples
BitsPerSample:     16 (unsigned integer)
SamplesPerPixel:   8
ExtraSamples:      5
Photometric:       RGB
BytesPerLine:      9600
Resolution:        (72.000000 x 72.000000) pixels per/inch
Compression:       LZW
Profile:           Embedded
 Version:          4.40
 Class:            ColorSpace
 Color Space:      RgbData
 Colorimetric PCS: XYZData
 Description:      RGB view of MultiSpectral 8 Channel Data
 Sub-Profile:      Embedded
  Version:          5.10
  Class:            ColorSpace
  SubClass:         'mspc' = 6D737063
  Color Space:      MCH8Data/8ColorData
  Spectral PCS:     0x0024ChannelReflectanceData
  Spectral Range:   start=380.0nm, end=730.0nm, steps=36
  Description:      Eight Channel Abridged Reflectance Encoder/Decoder


PS C:\tmp\fix\iccDEV\Testing\hybrid>
PS C:\tmp\fix\iccDEV\Testing\hybrid> dir .\Results\


    Directory: C:\tmp\fix\iccDEV\Testing\hybrid\Results


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         6/29/2026   5:08 PM              0 cmykGraysEst.txt
-a----         6/29/2026   5:08 PM              0 cmykGraysRef.txt
-a----         6/29/2026   5:08 PM          12880 LCDDisplayCat8Obs.icc
-a----         6/29/2026   5:16 PM        2174340 MS_smCows.tif

Checklist

  • Signed all Commits in PR
  • Built locally according to docs/build.md
  • Followed the guidelines in Contributing document
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

Legal Requirements

All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).

Contributor License Agreements

Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA)
.

There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.

  • If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.

  • If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement

License

ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.

Copyright Notices

All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.

INTELLECTUAL PROPERTY & PATENTS

Participation in ICC's development activities is subject to ICC's Patent Policy.

Maintainer Review Required

If you have questions, contact a listed Maintainer.

@xsscx xsscx linked an issue Jun 30, 2026 that may be closed by this pull request
@github-actions github-actions Bot added Tools Command-line tool or GUI tool changes Source C or C++ source code changes Configuration Repository, CMake, YAML, JSON, or tool configuration ci Continuous integration workflow changes github-actions GitHub Actions workflow or action configuration Windows Windows, MSVC, clang-cl, or PowerShell scope failed One or more CI checks failed pending CI checks still running and removed failed One or more CI checks failed pending CI checks still running labels Jun 30, 2026
@xsscx xsscx removed the failed One or more CI checks failed label Jun 30, 2026
@github-actions github-actions Bot added the failed One or more CI checks failed label Jun 30, 2026
@xsscx xsscx removed the failed One or more CI checks failed label Jun 30, 2026
@xsscx xsscx enabled auto-merge (squash) June 30, 2026 00:56
@github-actions github-actions Bot added the failed One or more CI checks failed label Jun 30, 2026
@xsscx xsscx removed the failed One or more CI checks failed label Jun 30, 2026
@xsscx xsscx force-pushed the ci-fix-tiff-regression branch from a0457bb to 12206fd Compare June 30, 2026 00:59
@github-actions github-actions Bot added the passed All CI checks passed label Jun 30, 2026
@xsscx xsscx marked this pull request as draft June 30, 2026 01:02
auto-merge was automatically disabled June 30, 2026 01:02

Pull request was converted to draft

@xsscx xsscx marked this pull request as ready for review June 30, 2026 01:02
@github-actions github-actions Bot added pending CI checks still running and removed passed All CI checks passed labels Jun 30, 2026
@xsscx

xsscx commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

2026-06-30 01:03:01 UTC

Stale API Queries.. Rerunning ci-pr-action just for good measurement

@github-actions github-actions Bot added passed All CI checks passed and removed pending CI checks still running labels Jun 30, 2026
@xsscx xsscx changed the title Ci fix tiff regression Fix: Bisect: 1f0a9dd | Windows Silent Failures Jun 30, 2026
@xsscx xsscx enabled auto-merge (squash) June 30, 2026 01:59
@xsscx xsscx merged commit 315c714 into master Jun 30, 2026
26 checks passed
@xsscx xsscx deleted the ci-fix-tiff-regression branch June 30, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration workflow changes Configuration Repository, CMake, YAML, JSON, or tool configuration github-actions GitHub Actions workflow or action configuration passed All CI checks passed Source C or C++ source code changes Tools Command-line tool or GUI tool changes Windows Windows, MSVC, clang-cl, or PowerShell scope

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bisect: 1f0a9dd | Windows Silent Failures

2 participants