Skip to content

fix: harden iccSpecSepToTiff CLI args#1604

Merged
xsscx merged 2 commits into
masterfrom
ci-fix-cli-iccspecsep
Jun 29, 2026
Merged

fix: harden iccSpecSepToTiff CLI args#1604
xsscx merged 2 commits into
masterfrom
ci-fix-cli-iccspecsep

Conversation

@xsscx

@xsscx xsscx commented Jun 29, 2026

Copy link
Copy Markdown
Member

PR Summary

Resolved iccSpecSepToTiff CLI Parsing #1603

2026-06-29 13:55:51 UTC

  1. compress and sep were documented as boolean (0 | 1), but code uses atoi(argv[2]) != 0 and atoi(argv[3]) != 0.
  2. Missing or unreadable optional profile was silently ignored
  3. Extra trailing arguments was ignored
  4. Ranges that do not land exactly on end were silently truncated

Checklist

  • Signed all Commits in PR
  • Built locally according to docs/build.md
  • Followed the guidelines in Contributing document
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

Legal Requirements

All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).

Contributor License Agreements

Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA)
.

There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.

  • If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.

  • If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement

License

ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.

Copyright Notices

All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.

INTELLECTUAL PROPERTY & PATENTS

Participation in ICC's development activities is subject to ICC's Patent Policy.

Maintainer Review Required

If you have questions, contact a listed Maintainer.

@xsscx xsscx linked an issue Jun 29, 2026 that may be closed by this pull request
@github-actions github-actions Bot added Tools Command-line tool or GUI tool changes Testing CTest, regression, or test coverage Source C or C++ source code changes Scripts Shell, PowerShell, or repository automation scripts Configuration Repository, CMake, YAML, JSON, or tool configuration Build Build system, CMake, compiler, or packaging Unix Linux, macOS, Bash, or POSIX shell scope labels Jun 29, 2026
@xsscx xsscx enabled auto-merge (squash) June 29, 2026 13:57
@github-actions github-actions Bot added pending CI checks still running failed One or more CI checks failed and removed pending CI checks still running labels Jun 29, 2026
@xsscx xsscx force-pushed the ci-fix-cli-iccspecsep branch from 28f4b61 to ff29e05 Compare June 29, 2026 14:13
@github-actions github-actions Bot added pending CI checks still running passed All CI checks passed and removed failed One or more CI checks failed pending CI checks still running labels Jun 29, 2026
@xsscx xsscx linked an issue Jun 29, 2026 that may be closed by this pull request
@github-actions github-actions Bot added pending CI checks still running and removed passed All CI checks passed labels Jun 29, 2026
@xsscx xsscx merged commit f9012f5 into master Jun 29, 2026
25 checks passed
@xsscx xsscx deleted the ci-fix-cli-iccspecsep branch June 29, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build system, CMake, compiler, or packaging Configuration Repository, CMake, YAML, JSON, or tool configuration pending CI checks still running Scripts Shell, PowerShell, or repository automation scripts Source C or C++ source code changes Testing CTest, regression, or test coverage Tools Command-line tool or GUI tool changes Unix Linux, macOS, Bash, or POSIX shell scope

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QA: Add CTest Spectral Corpus QA Report: iccSpecSepToTiff CLI Parsing

2 participants