feat(muon): split fused QKV projections - #2030
Open
RangiLyu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Muon should orthogonalize the logical projections inside a fused QKV weight independently.
Treating a fused QKV weight as a single matrix couples unrelated Q, K, and V updates during Newton-Schulz orthogonalization and applies learning-rate scaling based on the combined matrix shape.
This PR uses the
get_muon_split_sizes()interface introduced in #2001 to expose the logical row blocks of fused QKV parameters.Changes
in_proj_qkv.weight:key_dimkey_dimvalue_dimqkv.weight:dimdimdimThe Muon optimizer configuration discovers these mappings through the module-level
get_muon_split_sizes()interface and processes each logical projection independently.