fix cancel stopped seq#4654
Merged
Merged
Conversation
bbe56c3 to
b43fd36
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes cancellation behavior around “stopped” sequences in the PyTorch engine and tightens DP wakeup synchronization ordering to avoid races between wakeup and subsequent warmup/forward work.
Changes:
- Prevent
_on_stop_sessionfrom cancelling responses belonging to sequences alreadySTOPPEDorTO_BE_MIGRATED. - Ensure
EngineLoop._send_respprioritizesfinish=Trueoutputs over stale “done” (e.g., CANCEL) response states. - Move the DP post-wakeup barrier into
BaseModelAgent.wakeup()(scoped to the CPU process group) and add coverage for this ordering.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/pytorch/engine/test_model_agent.py |
Adds a unit test asserting DP wakeup triggers a barrier inside the wakeup RPC (after cache rebuild). |
tests/pytorch/engine/test_abort_stopped_seqs.py |
New tests covering “do not cancel already-stopped/to-be-migrated seqs” and “finish beats stale cancel” behavior. |
lmdeploy/pytorch/engine/model_agent/agent.py |
Relocates post-wakeup DP synchronization to wakeup() using dist_ctx.cpu_group. |
lmdeploy/pytorch/engine/engine.py |
Adjusts stop-session handling to avoid rejecting responses for already-stopped/to-be-migrated sequences. |
lmdeploy/pytorch/engine/engine_loop.py |
Updates response-type selection so out.finish takes precedence over resp.is_done. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b43fd36 to
94adf31
Compare
This reverts commit 94adf31.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix that cancel signal reset the status of finished seqs inside pt engine
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist