fix: updates to docker#1061
Merged
BenjaminMichaelis merged 3 commits intomainfrom May 6, 2026
Merged
Conversation
Addresses multiple items from the OWASP Docker Security Cheat Sheet: - Switch base image to mcr.microsoft.com/dotnet/aspnet:10.0-noble-chiseled (smaller attack surface, no shell, fewer CVEs, non-root by default) - Add USER app directive so container runs as non-root (OWASP Rule 2) - Remove curl|sh pattern for Azure Artifact Credential Provider - Replace raw PAT secret with BuildKit --mount=type=secret file (nugetconfig) so credentials are never written to any image layer or build cache - Generate NuGet auth config in CI via heredoc; clean up with if: always() - Fix PR docker build step: add context and ACCESS_TO_NUGET_FEED=false - Downgrade Node from non-LTS v25 to Active LTS v24 (Krypton)
- Add required=false to BuildKit secret mount so PR/merge_group builds succeed without the nugetconfig secret (was silently working due to dockerfile:1.2 syntax but required=false makes the intent explicit and safe for future syntax bumps) - Use NuGet config layering instead of --configfile: copy credentials-only secret into ~/.nuget/config/credentials.config so dotnet restore reads both the repo nuget.config (sources + packageSourceMapping) and the credentials file automatically - CI-generated config is now credentials-only (no packageSources, no packageSourceMapping) making nuget.config the single source of truth - no more drift risk
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…y-compliance-review # Conflicts: # .github/workflows/Build-Test-And-Deploy.yml # EssentialCSharp.Web/Dockerfile Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Contributor
Resolved in b8d18b9. Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes here.
Fixes #Issue_Number (if available)
Ensure that your pull request has followed all the steps below: