[MAINT] Add pre commit hooks - #94
Merged
Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
February 26, 2026 09:20
ndgrigorian
changed the base branch from
master
to
feature/add-numpy-random-interface
February 26, 2026 09:20
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
2 times, most recently
from
February 26, 2026 21:20
321ba3b to
f9cfa6e
Compare
ndgrigorian
marked this pull request as draft
February 26, 2026 22:08
Collaborator
Author
|
these changes have (by some twisted miracle) introduced build failures—but only on Windows. I will have to undo and find the root cause of this. |
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
February 27, 2026 00:43
f9fdc04 to
dbdcae3
Compare
ndgrigorian
marked this pull request as ready for review
February 27, 2026 00:48
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
February 27, 2026 01:00
dbdcae3 to
4ca26c7
Compare
ndgrigorian
marked this pull request as draft
February 27, 2026 01:00
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
February 27, 2026 01:27
4ca26c7 to
bf54ddc
Compare
Collaborator
Author
seems clang-format caused it, likely order of includes. I will exclude include blocks from clang-formatting |
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
3 times, most recently
from
February 27, 2026 03:52
715bb4f to
e5b5825
Compare
ndgrigorian
marked this pull request as ready for review
February 27, 2026 03:52
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
3 times, most recently
from
February 27, 2026 18:52
ce639f1 to
ec87861
Compare
ndgrigorian
force-pushed
the
feature/add-numpy-random-interface
branch
from
February 27, 2026 19:25
e612350 to
5ffbb5a
Compare
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
February 27, 2026 19:26
ec87861 to
47953a2
Compare
antonwolfy
reviewed
Feb 27, 2026
Collaborator
Author
|
@antonwolfy |
antonwolfy
reviewed
Mar 1, 2026
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
March 2, 2026 06:23
da6a0b1 to
e110065
Compare
antonwolfy
previously approved these changes
Mar 2, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @ndgrigorian
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
March 2, 2026 23:24
e110065 to
66e112e
Compare
ndgrigorian
force-pushed
the
feature/add-numpy-random-interface
branch
from
March 2, 2026 23:46
72c1025 to
14e0dac
Compare
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
March 2, 2026 23:50
66e112e to
68819e2
Compare
ndgrigorian
changed the base branch from
feature/add-numpy-random-interface
to
master
March 4, 2026 18:36
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
2 times, most recently
from
March 4, 2026 18:58
fbd5ce3 to
c5fcfa6
Compare
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
March 4, 2026 19:08
c5fcfa6 to
a338c4d
Compare
antonwolfy
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds pre-commit hooks to the project, following similar work last year in
mkl_fftAlso updates to conform with new linters (including cython-lint), adds a pre-commit check workflow, and adds changes to
.git-blame-ignore-revsCloses #61