Skip to content

task: remove numpy-base toggle#318

Open
jharlow-intel wants to merge 1 commit intomasterfrom
task/rmv-numpy-base
Open

task: remove numpy-base toggle#318
jharlow-intel wants to merge 1 commit intomasterfrom
task/rmv-numpy-base

Conversation

@jharlow-intel
Copy link
Copy Markdown
Contributor

Internal CI should now build and test fine without this toggle

Copilot AI review requested due to automatic review settings May 5, 2026 14:02
@jharlow-intel jharlow-intel self-assigned this May 5, 2026
@jharlow-intel
Copy link
Copy Markdown
Contributor Author

Do we still need the split recipes, now? Or can we consolidate it into 1 recipe again? @ndgrigorian @antonwolfy

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the Intel-channel conda recipe by removing the USE_NUMPY_BASE environment-variable toggle and standardizing the recipe to always depend on numpy, consistent with the expectation that internal CI no longer requires numpy-base.

Changes:

  • Removed the Jinja2 USE_NUMPY_BASE toggle logic from conda-recipe/meta.yaml.
  • Standardized ignore_run_exports, host, and run requirements to use numpy (with numpy >=1.26.4 at runtime).

@antonwolfy antonwolfy added this to the 2.3.0 release milestone May 5, 2026
@antonwolfy
Copy link
Copy Markdown
Collaborator

Do we still need the split recipes, now? Or can we consolidate it into 1 recipe again? @ndgrigorian @antonwolfy

Do you mean to merge with cf reciepe?

@jharlow-intel
Copy link
Copy Markdown
Contributor Author

Do we still need the split recipes, now? Or can we consolidate it into 1 recipe again? @ndgrigorian @antonwolfy

Do you mean to merge with cf reciepe?

Yes

@antonwolfy
Copy link
Copy Markdown
Collaborator

antonwolfy commented May 5, 2026

Do we still need the split recipes, now? Or can we consolidate it into 1 recipe again? @ndgrigorian @antonwolfy

Do you mean to merge with cf reciepe?

Yes

There are still different build scripts.

Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jharlow-intel
LGTM with small nit: please update the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants