Remove obsolete array API skip for test_dunder_dlpack - #3061
Draft
antonwolfy wants to merge 1 commit into
Draft
Conversation
The upstream fix for data-apis/array-api-tests#456 has been merged, so `test_dunder_dlpack` no longer needs to be skipped: it now tolerates the spec-mandated BufferError for a no-copy cross-device export, which dpnp already raises correctly. The conformance job checks out the array-api-tests default branch (unpinned), so the fix is already picked up.
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3061/index.html |
Collaborator
|
coverage: 78.494% (+0.003%) from 78.491% — remove-dlpack-array-api-skip into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev8=py314ha0e2e8e_2 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array API conformance job skipped
test_dlpack.py::test_dunder_dlpackas a workaround for a bug in the test itself (tracked in array-api-tests#457): the test pinned the requesteddl_devicetokDLCPUwhile drawingcopyfrom{True, False, None}, so on a SYCL device (reported askDLOneAPI) thecopy=Falsecase forced a cross-device transfer and the spec-mandatedBufferErrorwas counted as a failure.The upstream test has since been fixed to tolerate
BufferErroronly whencopy is Falseand the requested device differs from the array's own__dlpack_device__()— behavior dpnp already implements correctly by delegating to dpctl. The conformance job checks out the array-api-tests default branch without pinning a ref, so the fix is already picked up on new runs and the skip is now dead weight.This change removes only that entry. The remaining
tanhspecial-case skip is unrelated (an open array-api spec issue) and is left in place.