Skip to content

Ignore ruff PLR0917 to unblock lint#90

Merged
JE-Chen merged 1 commit into
mainfrom
dev
Jul 25, 2026
Merged

Ignore ruff PLR0917 to unblock lint#90
JE-Chen merged 1 commit into
mainfrom
dev

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Jul 25, 2026

Copy link
Copy Markdown
Member

Ruff is installed unpinned in CI (pip install ruff mypy), and a recent release stabilised PLR0917 (too-many-positional-arguments) out of preview. The scheduled main run went red on unchanged code:

  • automation_file/local/data_ops.py:66 _stream_csv_filter (7)
  • automation_file/local/data_ops.py:102 _write_filtered_rows (6)
  • automation_file/remote/http_download.py:182 download_file (8)

Adds PLR0917 to the ignore list next to the existing PLR0913 entry. download_file is exported on the facade and takes its arguments positionally with defaults, so making the signature keyword-only would break callers. The two data_ops helpers already carried # pylint: disable-next=too-many-positional-arguments, so the exemption was pre-existing intent.

Verified locally against ruff 0.15.14: ruff check and ruff format --check both pass.

@sonarqubecloud

Copy link
Copy Markdown

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen
JE-Chen merged commit 94b0f67 into main Jul 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant