Skip to content

feat: add relay systemd install with enroll method - #323

Merged
sheensantoscapadngan merged 8 commits into
mainfrom
feat/add-relay-systemd-install-with-enroll-method
Jul 24, 2026
Merged

feat: add relay systemd install with enroll method#323
sheensantoscapadngan merged 8 commits into
mainfrom
feat/add-relay-systemd-install-with-enroll-method

Conversation

@sheensantoscapadngan

@sheensantoscapadngan sheensantoscapadngan commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description 📣

This PR adds enrollment-based systemd installation for relays. The main changes are:

  • Token enrollment before installing an org relay service.
  • AWS authentication configuration for service startup.
  • Positional relay names with legacy install compatibility.
  • New relay environment keys and systemd configuration writers.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-323-feat-add-relay-systemd-install-with-enroll-method

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@sheensantoscapadngan
sheensantoscapadngan marked this pull request as ready for review July 22, 2026 15:15
Comment thread packages/relay/systemd.go Outdated
@veria-ai

veria-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Security review

No open security issues remain on this pull request.

Fixed/addressed: 2 · PR risk: 0/10

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds enrollment-based systemd installation for relays. The main changes are:

  • Token enrollment before installing an org relay service.
  • AWS authentication configuration for service startup.
  • Positional relay names with legacy install compatibility.
  • New relay environment keys and systemd configuration writers.

Confidence Score: 4/5

Token-enrolled services can select the wrong startup path, and invalid enrollment methods can install the wrong authentication mode.

  • The token systemd configuration omits the mode consumed by relay start.
  • Unsupported method values fall through to the legacy org flow instead of being rejected.
  • The AWS writer persists its startup mode correctly.

packages/relay/systemd.go and packages/cmd/relay.go

Important Files Changed

Filename Overview
packages/cmd/relay.go Adds token, AWS, instance, and legacy systemd installation branches; unsupported enrollment methods incorrectly enter the legacy branch.
packages/relay/enroll.go Adds the environment key used to pass the selected enrollment method into relay startup.
packages/relay/systemd.go Adds token and AWS systemd configuration writers, but the token writer omits its required startup mode.

Reviews (1): Last reviewed commit: "feat: add relay systemd install with enr..." | Re-trigger Greptile

Comment thread packages/relay/systemd.go Outdated
Comment thread packages/cmd/relay.go
Comment thread packages/relay/systemd.go Outdated
Comment thread packages/cmd/relay.go Outdated
Comment thread packages/cmd/relay.go
Comment thread packages/cmd/relay.go
@sheensantoscapadngan
sheensantoscapadngan merged commit 7728122 into main Jul 24, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants