fix: the segments of the seekbar are now updated when changing video#48
Open
voltarinou wants to merge 1 commit into
Open
fix: the segments of the seekbar are now updated when changing video#48voltarinou wants to merge 1 commit into
voltarinou wants to merge 1 commit into
Conversation
the segments of the seekbar are now updated whenever the current metadata changes (like for example when changing the video played) this change fixes InfinityLoop1308/PipePipe#2397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the segments of the seekbar are only updated in 3 cases:
but the segments displayed on the seek bar should be updated whenever a new video is played.
since selecting a new video to play changes the current metadata, and the metadata are needed to update the segments of the seekbar I think this change is a good way to solve this bug
I tested it on a google pixel 8a and didn't notice any new bug
this change fixes #InfinityLoop1308/PipePipe#2397