Open
Conversation
…h how the German language works.
Collaborator
|
I'll mention this again for posterity: Since everything has been autogenerated so far, there's some interpolation and concatenation in those strings, leading to the suffixes and symbols just hanging out there in the string file. I've taken some time to look at Apple's resources for localization, and it looks like they have some nice ways to handle this cleanly. The code will get updated a decent amount though, so you may have to redo most of these strings. For the time being though, it may be worth merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the German localization.
Since the German language uses a different suffix letter to pluralize words, some strings are not quite ready. But this only applies to a few of them, so the majority is good to go.