Improve packaging#107
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors packaging/build tooling configuration by centralizing build-only package references, introducing a local .NET tool manifest for package validation, and extending CI to pack + validate produced NuGet packages.
Changes:
- Move
DotNet.ReproducibleBuildsandMinVerfrom per-project references to centralized global references. - Add a local tool manifest (
dotnet-tools.json) fordotnet-validateand wire tool restore + package validation into CI. - Adjust CI trigger branch to
mainand lock code coverage package version pending an upstream issue.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Immediate.Cache/Immediate.Cache.csproj | Removes per-project build-only package refs in favor of centralized configuration. |
| src/Immediate.Cache.Shared/Immediate.Cache.Shared.csproj | Adds a net11-specific Features flag and removes per-project build-only package refs. |
| src/Immediate.Cache.Analyzers/Immediate.Cache.Analyzers.csproj | Removes per-project build-only package refs in favor of centralized configuration. |
| Immediate.Cache.slnx | Adds the tool manifest file to the solution structure. |
| dotnet-tools.json | Introduces a local tool manifest for dotnet-validate. |
| Directory.Packages.props | Locks code coverage version and adds global package references for reproducible builds + MinVer. |
| .github/workflows/build.yml | Switches push trigger to main; adds tool restore, pack, and package validation steps. |
Coverage Report for CI Build 26904555701Warning No base build found for commit Coverage: 96.154%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.