fix: expand adapters patch to fix more PerFrameFunctionalGroupsSequen… - #146
Merged
Merged
Conversation
…ce crashes Adds null checks and optional chaining for PerFrameFunctionalGroupsSequence in: - insertPixelDataPlanar (lines 555, 557, 558, 568) - insertOverlappingPixelDataPlanar (line 821) - getSegmentData (lines 914, 926, 929) Fixes "Cannot read properties of undefined (reading 'length')" errors when loading SEG files without PerFrameFunctionalGroupsSequence.
igoroctaviano
requested a deployment
to
fork-pr-approval
October 5, 2026 20:03 — with 
GitHub Actions
Queued
GitHub Actions
Queued
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds null checks and optional chaining for DICOM SEG loading to handle missing/undefined PerFrameFunctionalGroupsSequence gracefully.
Changes in
labelmapImagesFromBuffer.js:Null checks for PerFrameFunctionalGroupsSequence
insertPixelDataPlanar(lines 555, 557, 558, 568)insertOverlappingPixelDataPlanar(line 821)getSegmentData(lines 914, 926, 929)Graceful error handling for missing segment index
throw new Errortoconsole.warnwithcontinue(line 580)Changes in
checkOrientation.js:Errors fixed:
DICOM Compliance:
Per DICOM PS3.3 C.7.6.16 and C.8.20.3.1, these functional groups are required but graceful degradation is preferred over hard failure when encountering non-compliant files.
Related Upstream PR:
cornerstonejs/cornerstone3D#2963