fix: use idc-dicomweb as default data source instead of merge - #143
Merged
Merged
Conversation
The merge data source was causing "no DICOMweb base url provided" errors because it always tries to initialize ALL child data sources, including the GCP data source which has no URL when there's no ?gcp= query param. Change defaultDataSourceName from 'idc-merge' to 'idc-dicomweb' in: - idc-assets/app-config-template.js (production deployment) - platform/app/public/config/default.js (local dev) - platform/app/public/config/idc.js (local dev) The GCP extension will dynamically activate a merge data source when the ?gcp= query param is present.
igoroctaviano
requested a deployment
to
fork-pr-approval
October 5, 2026 15:40 — with 
GitHub Actions
Queued
GitHub Actions
Queued
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultDataSourceNamefromidc-mergetoidc-dicomwebin the production deployment config (idc-assets/app-config-template.js)Problem
When
defaultDataSourceNameis set toidc-merge, the merge data source initializes ALL child data sources including the GCP source. When the?gcp=query parameter is absent, the GCP data source has no URL configured, causing the error.Solution
Use
idc-dicomwebas the default data source. The GCP extension will activate the merge data source only when needed (when?gcp=param is present).Test plan
?gcp=parameter is provided