fix: CI and deployment fixes for OHIF 3.13 migration - #142
Merged
Merged
Conversation
- Add full data source configuration to idc.js including idc-dicomweb, gcp, and idc-merge data sources (was missing, causing "no DICOMweb base url provided" errors) - Add experiments.newCache for rspack 2.x filesystem cache compatibility - Update idc.js with OHIF 3.13+ customization service format - Add IDC branding, hotkeys, and mode visibility configuration
- Regenerate @cornerstonejs/core patch to fix toLowHighRange throwing "Invalid VOI LUT function" error for unknown VOI LUT function values - Remove outdated patch files that no longer apply cleanly - Add getValidVOILUTFunction helper that validates and normalizes VOI LUT function values, falling back to LINEAR for invalid values
igoroctaviano
requested a deployment
to
fork-pr-approval
October 5, 2026 15:03 — with 
GitHub Actions
Queued
GitHub Actions
Queued
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experiments.newCachefor filesystem cache compatibility with rspack 2.x@cornerstonejs/corepatch to fix "Invalid VOI LUT function" errorsidc-dicomwebas default data sourceRoot Cause
The
defaultDataSourceNamewas set toidc-mergewhich always tries to initialize ALL child data sources (IDC + GCP). When there's no?gcp=query parameter, the GCP data source has no URL configured, causing requests to useundefinedas the base URL.Changes
CI Fix
pnpm-workspace.yamlgithub:ImagingDataCommons/ohif-gcp-extension#mainandgithub:ImagingDataCommons/ohif-gcp-mode#mainrefsBuild Fix (
.webpack/webpack.base.js)experiments.newCachefor rspack 2.x filesystem cache compatibilityCornerstone Patch (
patches/@cornerstonejs__core.patch)toLowHighRangethrowing "Invalid VOI LUT function" for unknown valuesgetValidVOILUTFunctionhelper that falls back to LINEAR for invalid valuesData Source Fix (Critical)
defaultDataSourceNamefrom'idc-merge'to'idc-dicomweb'in:idc-assets/app-config-template.js(production deployment)platform/app/public/config/default.js(local dev)platform/app/public/config/idc.js(local dev)?gcp=param is presentTest plan
?gcp=param (should useidc-dicomwebdirectly)?gcp=param (should use merge data source)